https://bugzilla.redhat.com/show_bug.cgi?id=1121745

Remi Collet <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review?



--- Comment #2 from Remi Collet <[email protected]> ---
I was hoping someone else will review, this package... seems bad practice to
review one of myspec... so will only review the change...

About
BuildRequires:  php-cli

Strangely is works... (and pull php53-cli)
I would have have prefer
  BuildRequires:  php-cli > 5.3
or 
  BuildRequires:  php53-cli


Minor issue in the inter-package dependencies.
In php53-tcpdf-gnufree*, missing
Requires:       %{name} = %{version}-%{release}

See
http://pkgs.fedoraproject.org/cgit/php-tcpdf.git/commit/?id=7e768582a676e481024a96fe6ef2091fafef8c6c

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7603707

Installation test:
# yum --nogpgcheck localinstall /tmp/php53-tcpdf*
...
Installing:
 php53-tcpdf                               noarch                  
6.0.091-1.el5.centos                   /php53-tcpdf-6.0.091-1.el5.centos.noarch
 php53-tcpdf-dejavu-lgc-sans-fonts         noarch                  
6.0.091-1.el5.centos                  
/php53-tcpdf-dejavu-lgc-sans-fonts-6.0.091-1.el5.centos.noarch
 php53-tcpdf-dejavu-lgc-sans-mono-fonts    noarch                  
6.0.091-1.el5.centos                  
/php53-tcpdf-dejavu-lgc-sans-mono-fonts-6.0.091-1.el5.centos.noarch
 php53-tcpdf-dejavu-lgc-serif-fonts        noarch                  
6.0.091-1.el5.centos                  
/php53-tcpdf-dejavu-lgc-serif-fonts-6.0.091-1.el5.centos.noarch
 php53-tcpdf-dejavu-sans-fonts             noarch                  
6.0.091-1.el5.centos                  
/php53-tcpdf-dejavu-sans-fonts-6.0.091-1.el5.centos.noarch
 php53-tcpdf-dejavu-sans-mono-fonts        noarch                  
6.0.091-1.el5.centos                  
/php53-tcpdf-dejavu-sans-mono-fonts-6.0.091-1.el5.centos.noarch
 php53-tcpdf-dejavu-serif-fonts            noarch                  
6.0.091-1.el5.centos                  
/php53-tcpdf-dejavu-serif-fonts-6.0.091-1.el5.centos.noarch
 php53-tcpdf-gnu-free-mono-fonts           noarch                  
6.0.091-1.el5.centos                  
/php53-tcpdf-gnu-free-mono-fonts-6.0.091-1.el5.centos.noarch
 php53-tcpdf-gnu-free-sans-fonts           noarch                  
6.0.091-1.el5.centos                  
/php53-tcpdf-gnu-free-sans-fonts-6.0.091-1.el5.centos.noarch
 php53-tcpdf-gnu-free-serif-fonts          noarch                  
6.0.091-1.el5.centos                  
/php53-tcpdf-gnu-free-serif-fonts-6.0.091-1.el5.centos.noarch
Installing for dependencies:
 dejavu-lgc-sans-fonts                     noarch                   2.33-4.el5 
                           epel
 dejavu-lgc-sans-mono-fonts                noarch                   2.33-4.el5 
                           epel
 dejavu-lgc-serif-fonts                    noarch                   2.33-4.el5 
                           epel
 dejavu-sans-mono-fonts                    noarch                   2.33-4.el5 
                           epel
 dejavu-serif-fonts                        noarch                   2.33-4.el5 
                           epel
 php53-bcmath                              x86_64                  
5.3.3-23.el5_10                        updates
 php53-cli                                 x86_64                  
5.3.3-23.el5_10                        updates
 php53-common                              x86_64                  
5.3.3-23.el5_10                        updates
 php53-gd                                  x86_64                  
5.3.3-23.el5_10                        updates
 php53-mbstring                            x86_64                  
5.3.3-23.el5_10                        updates
 php53-mcrypt                              x86_64                   5.3.3-1.el5
                           epel
 php53-tidy                                x86_64                   5.3.3-1.el5
                           epel
 php53-xml                                 x86_64                  
5.3.3-23.el5_10                        updates
...

So everything seems ok.
Just need to fix the inter-packages dependency.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to