Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=609352 Parag AN(पराग) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] AssignedTo|[email protected] |[email protected] Flag| |fedora-review+ --- Comment #1 from Parag AN(पराग) <[email protected]> 2010-06-30 02:32:29 EDT --- Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2282093 + rpmlint output for SRPM and for RPM. perl-Catalyst-Plugin-Unicode-Encoding.noarch: W: spelling-error %description -l en_US params -> paras, prams, para's perl-Catalyst-Plugin-Unicode-Encoding.src: W: spelling-error %description -l en_US params -> paras, prams, para's 2 packages and 0 specfiles checked; 0 errors, 2 warnings. ==> Can be ignored. + source files match upstream url (sha1sum) 5057de66200cd8e05b5bc36479c509cca6707a8e Catalyst-Plugin-Unicode-Encoding-1.0.tar.gz 5057de66200cd8e05b5bc36479c509cca6707a8e Catalyst-Plugin-Unicode-Encoding-1.0.tar.gz.srpm + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=6, Tests=43, 3 wallclock secs ( 0.03 usr 0.01 sys + 2.72 cusr 0.14 csys = 2.90 CPU) + Package perl-Catalyst-Plugin-Unicode-Encoding-1.0-1.fc14.noarch => Provides: perl(Catalyst::Plugin::Unicode::Encoding) = 1.0 Requires: perl(base) perl(Carp) perl(Encode) >= 2.21 perl(MRO::Compat) perl(strict) rpmlib(VersionedDependencies) <= 3.0.3-1 + Not a GUI application Here looks Requires: for dependent packages is needed in spec as its not extracted by rpm dependency generator. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
