https://bugzilla.redhat.com/show_bug.cgi?id=1062757
František Dvořák <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] | |ect.org --- Comment #4 from František Dvořák <[email protected]> --- Spec URL: http://scientific.zcu.cz/fedora/glite-lb-logger-msg-1.2.13-2/glite-lb-logger-msg.spec SRPM URL: http://scientific.zcu.cz/fedora/glite-lb-logger-msg-1.2.13-2/glite-lb-logger-msg-1.2.13-2.fc22.src.rpm %changelog * Fri Sep 26 2014 František Dvořák <[email protected]> - 1.2.13-2 - Added link to upstream man pages patch (In reply to Matěj Cepl from comment #3) > > Issues: > ======= > > [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. > Has been Patch1 filed upstream? Could you please refer URL of the > upstream ticket in the SPEC file? You're right, fixed (https://github.com/CESNET/glite-lb/commit/b92e20cc3a0c4088c74a7ce4c2b8e20dd7807a16). > [!]: Development files must be in a -devel package > I believe %{_libdir}/activemq_cpp_plugin.so should go to -devel > (also, there are no header files, are they?) This is the plugin and non-versioned link is used at runtime for loading it dynamically. It is built by libtool, which handles automatically the versioning. > [!]: %build honors applicable compiler flags or justifies otherwise. > Why do you call ./configure with explicit perl? ./configure has > correct shebang line and it is executable so it works without it. > There were a recommendation to not using absolute paths when invoking perl (https://bugzilla.redhat.com/show_bug.cgi?id=892597#c3): "Don't use absolute paths in your spec. Call perl simply 'perl' (preferred) or use the %{__perl} macro." (CCing also perl-devel list) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
