https://bugzilla.redhat.com/show_bug.cgi?id=1148049
Christian Krause <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] Assignee|[email protected] |[email protected] Flags| |fedora-review? --- Comment #2 from Christian Krause <[email protected]> --- Just a quick informal review. I can do the full review tomorrow. - rpmlint shows an error: vpnc-script.noarch: W: incoherent-version-in-changelog 020140705.git6201ebd ['20140705-1.git6201ebd.fc20', '20140705-1.git6201ebd'] - it looks like that upstream has included the unbound patch: http://git.infradead.org/users/dwmw2/vpnc-scripts.git/commit/df5808b301ba767578ffbec966db3b9ff154f588 Would it be possible to use that version without patching? - I would add an empty %build section to avoid an rpmlint warning - it shouldn't have any drawback and it will make it easier to spot new warnings - since vpnc-script was moved into its own sub-package, it was marked as config: %config(noreplace) %{_sysconfdir}/vpnc/vpnc-script I'm unsure whether any user has ever changed the script, but for 100% compatibility it should be marked the same. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
