Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603267

Stanislav Ochotnicky <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #1 from Stanislav Ochotnicky <[email protected]> 2010-07-01 
09:13:24 EDT ---
Few notes:
 * use %configure macro, this will set proper paths automatically
 * either use "make %{?_smp_mflags}" or explain why parallel builds are not
possible
 * why delete only README.windows and not others? Either delete/not install
readme files for hpux/ovms/solaris/and the rest or install all of them without
exceptions (the README.vmware~ is ok...obviously stale backup file)
 * you are missing %clean phase with rm -rf $RPM_BUILD_ROOT
 * netperf info file doesn't include INFO-DIR-SECTION therefore your post/preun
scriptlets are moot (you also checked for existence of wrong file so they were
never run). Either patch info/texi file to include proper dir section or do not
even call install-info (btw normally it is better to Require "info" then
"/sbin/install-info")

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to