https://bugzilla.redhat.com/show_bug.cgi?id=1150653
Dan Horák <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] Assignee|[email protected] |[email protected] Flags| |fedora-cvs+ --- Comment #1 from Dan Horák <[email protected]> --- formal review is here, see the notes explaining OK* and BAD statuses below: OK source files match upstream: 770c072c8111836a305a356dda24ff9e75c77e7c libosmo-dsp-0.3.tar.bz2 OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK license field matches the actual license. OK license is open source-compatible (GPLv2+). License text included in package. OK latest version is being packaged. OK BuildRequires are proper. OK* compiler flags are appropriate. OK package builds in mock (Rawhide/x86_64). OK debuginfo package looks complete. OK rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. Ok correct scriptlets present. OK code, not content. OK documentation is in -docs subpackage OK %docs are not necessary for the proper functioning of the package. OK headers in -devel subpackage OK pkgconfig files in -devel subpackage OK no libtool .la droppings. OK not a GUI app. - please run make with V=1 to see compiler command line in logs - rpmlint is harmless libosmo-dsp-devel.x86_64: W: only-non-binary-in-usr-lib libosmo-dsp-devel.x86_64: W: no-documentation the docs are in own subpackage The package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
