https://bugzilla.redhat.com/show_bug.cgi?id=1109717
Dmitry Tantsur <divius.ins...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |divius.ins...@gmail.com
--- Comment #7 from Dmitry Tantsur <divius.ins...@gmail.com> ---
Hi!
1. BuildRequires: python
should be
BuildRequires: python2-devel
2. find Evtx -name '*.py' | xargs sed -i '/\/usr\/bin\/python/d'
I think it would be better to check for shebang only, something like:
| xargs sed -i ''/^#!.*\/python/d'
3. Why not use summary and description from package's setup.py?
https://github.com/williballenthin/python-evtx/blob/master/setup.py
Also I think in "Programming documentation for %{name}" using full summary of
the base package would be more helpful for a user.
Newer build for reference:
http://koji.fedoraproject.org/koji/taskinfo?taskID=7811652
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
