https://bugzilla.redhat.com/show_bug.cgi?id=1151747
--- Comment #6 from Robert Mayr <[email protected]> --- Ok, a few other comments: 1) The guidelines for the github commit contain also a shortcommit instruction. I think it's better to add it. 2) You should use either $RPM_BUILD_ROOT or %{buildroot}, don't mix them up. 3) in the %files section you have %{_datadir}/* - is the package the owner of all the stuff beside it? It's better to define the single directories separately, IMHO. 4) Use valid macros for the name instead of hardcoding 5) Your desktop file has a deprecated "Encoding" instruction in the [Desktop Entry] section. https://developer.gnome.org/desktop-entry-spec/#deprecated-items -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
