https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #2 from Piotr Popieluch <[email protected]> ---
Thank you for reviewing.

I will fix the whitespaces.

I'm not sure about the "Requires: systemd" 
I've took this page as example
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd
They only require in post, preun, postun. I've checked a couple existing
packages and some only require post/pre others only include on "Requires:
systemd". It's not clear to me what 'the right way to do this' is.

I will make python2 explicit for now. It doesn't make sense to me to ship two
packages yet. I think the user will only use the python version which is
default with the OS. I will add python3 when it gets the default python (I
think it is scheduled for f22).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to