https://bugzilla.redhat.com/show_bug.cgi?id=1156657

Raphael Groner <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #1 from Raphael Groner <[email protected]> ---
> # Post-Release checkout containing some improvements
> Release:        1.%{checkout}%{?dist}
You should better use a timestamp additionally for a snapshot release
independently of pre/post-release logic. Cause if your checkout changes, you
would have to increase the main number also:
Release:        1.20141025svn%{checkout}%{?dist}
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages


> %install
> make install DESTDIR=%{buildroot}
%make_install
Please comment why you prefer DESTDIR usage.
https://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_.25makeinstall_macro_should_not_be_used

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to