https://bugzilla.redhat.com/show_bug.cgi?id=1154743

Parag AN(पराग) <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review?



--- Comment #1 from Parag AN(पराग) <[email protected]> ---
1) The given spec file and spec file packaged in SRPM is not same, I guess its
some whitespace issue. correct this by having same spec packaged in srpm.

2) Group tag is optional in fedora releases. You may want to remove it but not
mandatory

3) you should add license tag for python3-pretend also.

4) Its a good practice to remove any upstream supplied egg-info files in %prep
and have packaged the newly generated egg-info files.

rm -rf *.egg-info

Otherwise package looks fine.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to