Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=607778 Michael Schwendt <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #5 from Michael Schwendt <[email protected]> 2010-07-04 16:59:10 EDT --- Okay. The segfaults in the plugins will be left to you anyway. There are more, e.g. when starting from scratch and enabling "Leoslyrics". ABRT doesn't catch them: $ rm -rf ~/.config/xnoise $ xnoise LastfmCovers plugin failed to activate! Mediawatcher plugin failed to activate! *** glibc detected *** xnoise: malloc(): smallbin double linked list corrupted: 0x00000000015f5f50 *** $ rm -rf ~/.config/xnoise $ xnoise LastfmCovers plugin failed to activate! Mediawatcher plugin failed to activate! closing... Segmentation fault (core dumped) JFTR, the review guidelines say: | SHOULD: The reviewer should test that the package functions as | described. A package should not segfault instead of running, for example. We could go on with even more disabled plugins. Eventually, no plugin may be left. ;) Or old/new segfaults might return with one of the next updates after package approval. Whether 0.1.6 is ready for Rawhide, I leave this decision to you. [...] About the .pc file: Consider merging this dubious -devel subpackage into the xnoise-plugins-core package. Possibly with a virtual -devel pkg or only when you learn about something that would need such a BuildRequires. Rationale: xnoise-plugins-core builds the plugins with the .pc file in xnoise-devel, so external plugins will likely use that .pc file, too. [...] Other issues have been dealt with. As the xnoise-plugins-core-devel pkg may return after the review process or be killed again in future updates, it isn't necessary to insist on its removal during this review. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
