https://bugzilla.redhat.com/show_bug.cgi?id=1158629



--- Comment #4 from Jakub Kadlčík <[email protected]> ---
Thank you Miroslav,

I agree with everything, so 

> Do not repeat Subject in description. Simply remove that first sentence from 
> description.
Fixed

> Missing dot at the end.
Fixed

> I talked to Jan Zeleny and it is prefered to call the plugin 
> "dnf-plugin-tracer".
Renamed

> You do not need to list 
>   make
> as BuildRequires:
Fixed

> Either remove shebang, or set the executable flag. But having the file as 
> non-executable and have there shebang does not have sense.
Fixed

> Since Fedora 22 should have python3 as default, it is worth considering to 
> move to python3. But this is not blocker and can be addressed later.
It's a new for me that F22 should have python3 as default. In that case tracer
will be ready before its release.


There is link to new SRPM file:
http://tux.inf.upol.cz/~frostyx/SRPMS/tracer-0.5.4-1.fc20.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to