https://bugzilla.redhat.com/show_bug.cgi?id=1159874
Rex Dieter <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Rex Dieter <[email protected]> --- naming: ok license: ok, though all source files are LGPL (v2.1 or later) , so you could up to License: LGPLv2+ sources: ok c35c7f466e79142d6ee83e234a517f35 lxqt-policykit-0.8.0.tar.xz macros: ok scriptlets: ok, n/a 1. SHOULD document need for export CMAKE_PREFIX_PATH=%{_libdir}/cmake/PolkitQt5-1 (seems to build ok without it for me) 2. Ideally, this package probably SHOULD: * include an autostart .desktop file, and... * move the binary to %{_libexecdir} as other policykit agents work but we can deal with that post-review (in collaboration with upstream). Otherwise, pkg is small, clean, simple. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
