https://bugzilla.redhat.com/show_bug.cgi?id=1164478

Parag AN(पराग) <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review+



--- Comment #1 from Parag AN(पराग) <[email protected]> ---
Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-json-localizer.noarch: W: spelling-error %description -l en_US config ->
con fig, con-fig, configure
nodejs-json-localizer.noarch: W: only-non-binary-in-usr-lib
nodejs-json-localizer.src: W: spelling-error %description -l en_US config ->
con fig, con-fig, configure
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball: 5430e4a3e0d99ba0da7d8e4db76aeef06dbdc8bd740e7093b5ee2f2de408072f
upstream tarball:
5430e4a3e0d99ba0da7d8e4db76aeef06dbdc8bd740e7093b5ee2f2de408072f

+ License is "WTFPL".

+ follows nodejs packaging guidelines.

Suggestions:
1) Check if upstream can add license information in either its own file or in
index.js or in README.md

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to