https://bugzilla.redhat.com/show_bug.cgi?id=1166421

Piotr Popieluch <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #1 from Piotr Popieluch <[email protected]> ---
some comments:

- Add: BuildRequires: nodejs-packaging, see:
https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/Packagers#BuildRequires


rpmlint:
- Check tab and space usage, retab to spaces, remove spaces at end of line

- summary too long:
E: summary-too-long C Transformations between the Web Mercator projection and
Latitude Longitude coordinates

- Add: %check section, see test in package.json for how to test.

- Why is the > /dev/null in %install needed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to