https://bugzilla.redhat.com/show_bug.cgi?id=1170811

Parag AN(पराग) <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review?



--- Comment #1 from Parag AN(पराग) <[email protected]> ---
Review:

+ Package built successful in mock (f22 x86_64)

- rpmlint on generated rpms gave output
nodejs-clone.noarch: W: summary-not-capitalized C deep cloning of objects and
arrays
nodejs-clone.noarch: W: only-non-binary-in-usr-lib
nodejs-clone.src: W: summary-not-capitalized C deep cloning of objects and
arrays
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball: b55ad6319e733ae4d885f3ab2381249844768cf484054fa5c384d1941b8f7a74
upstream tarball: 
b55ad6319e733ae4d885f3ab2381249844768cf484054fa5c384d1941b8f7a74

+ License is "MIT".

- LICENSE file not included in %files

+ follows nodejs packaging guidelines.

Suggestions:
1) Fix rpmlint warning summary-not-capitalized

2) Add LICENSE in %doc

3) you should in %prep
rm -rf node_modules

4) Group tag is now optional so you can remove it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to