https://bugzilla.redhat.com/show_bug.cgi?id=1169140

Parag AN(पराग) <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review+



--- Comment #1 from Parag AN(पराग) <[email protected]> ---
Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-util.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-util.noarch: W: only-non-binary-in-usr-lib
nodejs-util.noarch: W: dangling-symlink
/usr/lib/node_modules/util/node_modules/inherits
/usr/lib/node_modules/inherits@2
nodejs-util.src: W: spelling-error %description -l en_US js -> dis, ks, j
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball: 88033ac0a981b3c3919d7bf21e9808d0a2903c331688e4122bdd32eeea3dd6d0
upstream tarball: 
88033ac0a981b3c3919d7bf21e9808d0a2903c331688e4122bdd32eeea3dd6d0

+ License is "MIT" and included in its own LICENSE file.

+ follows nodejs packaging guidelines.

Suggestions:
1) Group tag is optional, can be removed.

2) description can be same as %{summary}.
Node.js util module.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to