https://bugzilla.redhat.com/show_bug.cgi?id=1172414

Mamoru TASAKA <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review?



--- Comment #1 from Mamoru TASAKA <[email protected]> ---
Some notes:

- Licensing

Well, this package is a bit hard because the source
tarball contains 8119 files, with 3 of them are .tar.gz
which contains another 49 files.

From the point of view with regard to licensing check
my first "grep"ing classified 6115 files, I had to check
the rest ~2000 files with my eyes. While I may have overlooked
something, one thing I detected:

* APSL 1.1 
  - not sure for 1.1, however APSL 2.0 is marked as
    incompatible with GPL 
testcases/kernel/fs/fsx-linux/fsx-linux.c

- Debuginfo issue
I think using
%undefine _missing_build_ids_terminate_build
is better than removing executable permission from
.obj files (not linked, missing build-id).

Full review follows. By the way, I would appreciate it
if you would review my review request (bug 1171991)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to