https://bugzilla.redhat.com/show_bug.cgi?id=821917



--- Comment #22 from Michael Schwendt <[email protected]> ---
Several points raised in comment 17 remain.


Additionally:

* build.log output mentions "make check". This could be done in the %check
section of the spec file. If it cannot be done, the spec file should tell.

* guile-%{name} and guile-mu are mixed throughout the spec file. That decreases
readability, since %name is "mu" too.

* /usr/share/mu and /usr/share/mu/scripts directories are not included:
https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership


> %files -n guile-%{name}-devel
> %{_libdir}/libguile-mu.so

Moving this library into a -devel package means that one could not use Guile
for running Scheme scripts, because this is a runtime file for scripts, not a
build-time file:
https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to