https://bugzilla.redhat.com/show_bug.cgi?id=1150566

[email protected] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #1 from [email protected] ---
Greetings,

You should use %license for LICENSE instead of %doc.

There is no man file. You should probably need to work with upstream to write
it. It could be written in markdown and you could always convert it to man
while packaging, e.g.

%build
pandoc -s -f markdown_github -t man -V title=%{name} -V section=1 -V
date="$(LANG=C date -d @$(stat -c'%Z' README.md) +'%B %d, %Y')" README.md -o
%{name}.1

Remove any comments from SPEC that you don't need.

Replace spaces to tabs (line 25).

You might want your SPEC to produce hardened binaries
(http://fedoraproject.org/wiki/Packaging:Guidelines#PIE).

Please note that this is informal review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to