https://bugzilla.redhat.com/show_bug.cgi?id=1174290

[email protected] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #1 from [email protected] ---
Greetings,

why do you need "rm -rf $RPM_BUILD_ROOT" in %install and %clean ?
It seems that you are not packaging this for EL5/F12 and below so you could
easily remove it.

You should also use %license for COPYING instead of %doc.

Please note that this is informal review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to