https://bugzilla.redhat.com/show_bug.cgi?id=1172800
Zbigniew Jędrzejewski-Szmek <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Assignee|[email protected] |[email protected] Flags| |fedora-review? --- Comment #5 from Zbigniew Jędrzejewski-Szmek <[email protected]> --- The way the version is defined is unusual. Why not simply remove %{commit} and use %{version} everywhere instead? Use %license not %doc for COPYING COPYING-LGPLV3. You could also duplicate that in the -devel package, without depending on an implicit dependency. Not strictly necessary, but it would save a few lines to do: make -C build install ... make -C build test Requires: elfutils-devel%{?_isa} = %{version}-%{release} is bad. This makes it impossible to e.g. fix a packaging bug in just one of those packages without requiring a spurious rebuild of the other one. Also elfutils-devel has version 0.160 here, so it actually makes the package uninstallable. I think the "dwgrep-" component in library subpackages is unnecessary. Just call them libzwerg, libzwerg-devel (use %package -n libzwerg, etc.). You must add Provides: bundled(jquery). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
