https://bugzilla.redhat.com/show_bug.cgi?id=1176277



--- Comment #3 from Raphael Groner <[email protected]> ---
(In reply to Ivan Romanov from comment #2)
> sed script in %build section is not the sane. I think here SHOULD be used
> patch.
A patch may neither be of more help here, so I could use my own ninja.build
file in complete. Reported with request for configure to upstream: 
https://github.com/Rapptz/Shinobi/issues/1

> What is %{sample} ? How you got this?
> What do diff in %check section?
The sample is copied from the README.md file with a little modification cause I
think there's a bug. This file should generate a ninja.build file for Shinobi
itself, so let's use it as an expectation (renamed reference to be clearer),
compare both in %check section to know if shinobi command works and diff will
report any error.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to