https://bugzilla.redhat.com/show_bug.cgi?id=1132670
--- Comment #7 from Mo Morsi <[email protected]> --- (In reply to Vít Ondruch from comment #6) > * Test suite > - I'd suggest to execute the test suite using following command: > > ruby -Ilib:test/units \ > -e 'Dir.glob "./test/units/*_test.rb", &method(:require)' Updated > > - Please expand the test suite in %check section. This way you keep in RPM > just the content which was originally shipped by upstream. This also > avoids > several rpmlint complains. Assuming this meant exclude the test suite in the %files section. In which case done. > - It seems that the timecop and true are needed just for integration > tests. Since there is circular dependency between true and compass, I'd > suggest to use boostrap macro [1] to disable the integration tests during > bootstrap. Currently the integration tests are not being run anyways so just ommitting this extra bit since its not needed. Once true is in we can update the spec to run those tests. > > Otherwise the package is legit => APPROVED > Thanks Final spec: https://mmorsi.fedorapeople.org/staging/rubygem-compass-core.spec Final srpm: https://mmorsi.fedorapeople.org/staging/rubygem-compass-core-1.0.1-4.fc22.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8467442 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
