https://bugzilla.redhat.com/show_bug.cgi?id=1176277

Björn "besser82" Esser <bjoern.es...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(dr...@land.ru)



--- Comment #16 from Björn "besser82" Esser <bjoern.es...@gmail.com> ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


===== MUST items =====

Generic:
[!]: %build honors applicable compiler flags or justifies otherwise.

---> build is performed ***WITHOUT*** any CFLAGS nor LDFLAGS!!!

[!]: Useful -debuginfo package or justification otherwise.

---> debuginfo ist empty!!!

[x]: Package complies to the Packaging Guidelines
[!]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.

---> Compiler / Linker -flags are ***NOT*** applied properly.


===== SHOULD items =====

Generic:
[!]: Packages should try to preserve timestamps of original installed files.

---> timestamps of %doc and %license are modified during %prep.


===== Solution =====

Epic review-fail!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to