https://bugzilla.redhat.com/show_bug.cgi?id=1179173
Rex Dieter <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1179172 (plasma-workspace) --- Comment #1 from Rex Dieter <[email protected]> --- sources: ok cd5dbce577c175cb33008702400d5598 plasma-desktop-5.1.2.tar.xz naming: ok (Mostly) 1. SHOULD omit "5" from pkg Summary , ie Summary: Plasma Desktop less worries when/if Plasma 6 appears, or maybe just not worry that far ahead :) scriptlets: NOT ok 2. MUST add icon-cache scriptlets due to %{_datadir}/icons/*/*/*/* 3. MUST validate application .desktop files %{_datadir}/applications/*.desktop macros: ok I'll review relevant runtime deps from kde-workspace, and whether any/all should be added here or not, but that's not a review blocker either. license: NOT ok 4. there seems to be GPLv2-only bit: kcms/componentchooser the rest is fairly GPLv2 or GPLv3 (or upgradable from LGPL), I guess we'll have to go with: # kcms/componentchooser is GPLv2 only # rest is GPLv2 or GPLv3 (or upgradable from LGPL) License: GPLv2 and (GPLv2 or GPLv3) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1179172 [Bug 1179172] Review Request: plasma-workspace - Plasma 5 workspace applications and applets -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
