https://bugzilla.redhat.com/show_bug.cgi?id=1182261
Richard Shaw <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Richard Shaw <[email protected]> --- Ok, pardon my ignorance but as you work at RedHat, do you actually require sponsoring to be a Fedora packager or are you already sponsored? Quick spec file review: No major problems jump out at me so very good! Minor nits: 1. It's preference, not required, but it's a good idea to list your BuildRequires on separate lines. About the only time I list multiple is if they are closely related (autoconf, automake) or let's say you have something that manipulates images then I could see having all the image devel libraries on one line. 2. Requires from the devel package should be arch specific, i.e.: Requires: %{name} = %{version}-%{release} to: Requires: %{name}%{?_isa} = %{version}-%{release} 3. In install since your not doing anything out of the ordinary you could use the "%make_install" macro. 4. In %files unless your using non-default permissions you don't need %defattr. 5. Typically %doc is right under %files. It's not wrong to do so but it's unusual. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
