https://bugzilla.redhat.com/show_bug.cgi?id=1181118
Zbigniew Jędrzejewski-Szmek <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Assignee|[email protected] |[email protected] Flags| |fedora-review? --- Comment #1 from Zbigniew Jędrzejewski-Szmek <[email protected]> --- 1. remove pkgdocdir definition, Fedora versions which didn't have this are EOL 2. remove BuildRoot 3. remove rm -rf %{buildroot} (Are you really building this for RHEL5 too? Then I guess 1-4 can be ignored). 4. remove %clean 5. %description reads like an advertisement. It should at least mention what "grid" is. Who develops it is not crucial. Also the last paragraph "The %{name package contains..." is not really useful, since it repeats the Summary. 7. consider using %license for GLOBUS_LICENSE (and add %global _docdir_fmt %{name} to avoid having multiple copies) 8. %files should have (note extra dot) %{_libdir}/libglobus_net_manager.so.* 9. where does Source8 come from? 10. Consider using %make_install instead of the open-coded version. 11. -docs is preferred to -doc for the package name. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
