https://bugzilla.redhat.com/show_bug.cgi?id=1077030
Miroslav Suchý <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #4 from Miroslav Suchý <[email protected]> --- You are missing dot at the end of %description of python3 subpackage. It is habit (but just habit) to put %check section between %install and %files. I would consider putting htmldocds in separate -doc subpackage. But I will accept if you hesitate to create it. Is this: python3 -c 'import locale; print(locale.getpreferredencoding(False))' needed. Or it is just forgotten statement? Beside that, it looks good. Normally, I would approve this package (because nothing is really blocker), but because this is your first package in Fedora I would kindly ask you to address these issues first. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
