https://bugzilla.redhat.com/show_bug.cgi?id=1183169



--- Comment #2 from Benjamin Pereto <[email protected]> ---
Hi,

Thank you for your notes. I updated the spec file.

> you should use macro for various path ( /usr/lib/systemd/system for example )

I have the problem, that ex. _libdir is translated to /usr/lib64 on x86_64
systems. no I have changed it to %{_usr}/lib.
Is there another way?

> i would recommand having 1 buildRequires per line, since that's easier to 
> review on git when there is a change ( ie, in the diff )

I changed it that way.

> i would recommand having 1 buildRequires per line, since that's easier to 
> review on git when there is a change ( ie, in the diff )

this case the systemd-service is not required. if you want to change the
challenges, then you should.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to