https://bugzilla.redhat.com/show_bug.cgi?id=1162234
--- Comment #7 from Sinny Kumari <[email protected]> --- (In reply to Giuseppe Paterno' from comment #6) > Dear Sinny, > thanks for the review, probably the best one I had up to now. > I hope I have corrected most of the issues you mentioned. Yes, you have made changes for most of issues pointed out by me. Few more feedback: * For Changelog I have seen using angle bracket instead of parenthesis for specifying email address http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs . Should be Wed Jan 28 2015 Giuseppe Paterno' <[email protected]> 0.2-2 * It would be good and consistent too if you update source tar file name to nss-securepass-%{commit}.tar.gz from nss_securepass-%%{commit}.tar.gzin order to keep consistent with spec and srpm file Rest I don't see any major issue. It would be good if fedora packager can review it further. Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
