https://bugzilla.redhat.com/show_bug.cgi?id=1186572
--- Comment #1 from František Dvořák <[email protected]> --- Interesting package with many tricks, and it looks good (exact launch of the tests, package rename, ...). Issues to consider: 1) %global should be preferred over %define [http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define] - %define is considered less "predictable" than %global (although I don't understand the details) 2) the format security patch should be submitted upstream [http://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment] 3) permissions of doc/ex/images/logo400x83.gif can be fixed too 4) what is the %{nil} after the rm command good for? (in %install section) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
