Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226615

Thomas Spura <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected],
                   |                            |[email protected],
                   |                            |[email protected]
         AssignedTo|[email protected]    |[email protected]
               Flag|                            |fedora-review?

--- Comment #1 from Thomas Spura <[email protected]> 2010-07-14 
08:30:24 EDT ---
Review:

GOOD:
- $rpmlint ./xorg-x11-drv-penmount-1.4.0-7.fc13.src.rpm ./x86_64/xorg-x11-drv-
  penmount-*
  xorg-x11-drv-penmount.src: W: invalid-url Source0: ftp://ftp.x.org/pub/
  individual/driver/xf86-input-penmount-1.4.0.tar.bz2 <urlopen error ftp error: 
  timed out>
  3 packages and 0 specfiles checked; 0 errors, 1 warnings.

  False positive, the file is there.
- name ok
- license ok
- group ok
- BR/R ok
- source matches upstream: d5f1395b2dcefc7533ff5580e63f2066
- no locale files
- lib proberly packaged
- no .la files
- nothing static


NEEDSWORK:
- please add a proper COPYING file upstream
- a new version 1.4.1 is available
- please use parallel make:
  https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make
- please use INSTALL="install -p", when installing, to preserve timestamps
- please add COPYING Changelog and README to %doc

(CC'ing Peter Hutterer and Adam Jackson, because they used to update this
package.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to