Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=614196

Martin Gieseking <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #1 from Martin Gieseking <[email protected]> 2010-07-14 
13:45:15 EDT ---
Hi Mattias,

here are some quick comments:

- rpmlint emits two errors concerning wrong file permissions. The latter should
be set to 755:

$ rpmlint /var/lib/mock/fedora-13-x86_64/result/*.rpm|fgrep E:
gccxml.x86_64: E: non-executable-script
/usr/share/gccxml-0.9/IBM/find_flags_common 0644L /bin/sh
gccxml.x86_64: E: non-executable-script
/usr/share/gccxml-0.9/Sun/find_flags_common 0644L /bin/sh

- I'm not sure about the overall license because several licenses are involved:
  + gccxml seems to be licensed under BSD
  + the bundled gcc libraries are licensed under LGPLv2+
  + the included GCC sources are licensed under GPLv2+
  ==> this would lead to GPLv2+ for the package
  + some of the packaged header files are licensed under GPLv3+ with
exceptions,
    e.g. GCC_XML/Support/GCC/4.5/iomanip
  ==> has this to be reflected in the License field?

- Only the BSD license text is currently packaged. If the resulting license is
GPLv2+, GCC/COPYING should be added to %doc.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to