https://bugzilla.redhat.com/show_bug.cgi?id=1190046
Parag AN(पराग) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] | |ect.org, | |[email protected] | |ct.org, [email protected] Assignee|[email protected] |[email protected] Flags| |fedora-review? --- Comment #1 from Parag AN(पराग) <[email protected]> --- Review: + Mock build is successful for F22(x86_64) + rpmlint output on all generated rpm looks good 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + Source verified with upstream as (sha356sum) upstream source: 16cfec294d7364513e026ac2ff82ac30395ce33dcd4eb2fb559f109193166a1b srpm source: 16cfec294d7364513e026ac2ff82ac30395ce33dcd4eb2fb559f109193166a1b + License "OFL" is valid and included in source files. + fontconfig file looks good + font metadata information is present Suggestions: 1) Please properly truncate description lines to 80 characters whereaver possible. It should look like this %description Avería is a Unicode typeface family created from the average of all fonts on the computer of the creator, Dan Sayers. The process is described at http://iotic.com/averia/. All metrics are the result of an averaging process. 2) Try to have summary, description unique to packaged font. Summary: Averia font family 3) use oflb as foundry 4) From the FONTLOG.txt it looks like you can use version as 1.01 5) $ appstream-util validate averia.metainfo.xml averia.metainfo.xml: FAILED: • markup-invalid : <id> does not have correct extension for kind • tag-missing : <extends> is not present • style-invalid : <summary> requires sentence case • style-invalid : <p> cannot contain a hyperlink • style-invalid : Not enough <p> tags for a good description Validation of files failed So fix 3rd and 4th message from above. 6) fontconfig need to be fixed as this is just "serif" font. don't forget to increase the release number and add corresponding changes in changlog or just say "fixed as per review comments" like in changelog. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
