https://bugzilla.redhat.com/show_bug.cgi?id=1190048
Parag AN(पराग) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] | |ect.org, | |[email protected] | |ct.org, [email protected] Assignee|[email protected] |[email protected] Flags| |fedora-review? --- Comment #1 from Parag AN(पराग) <[email protected]> --- Review: + Mock build is successful for F22(x86_64) + rpmlint output on all generated rpm looks good 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + Source verified with upstream as (sha356sum) upstream source: 5e0783209552d6a6d3f58b2fa8c191d8331fe60a29ed17576d6bdd5614a6eb2c srpm source: 5e0783209552d6a6d3f58b2fa8c191d8331fe60a29ed17576d6bdd5614a6eb2c + License "OFL" is valid and included in source files. + fontconfig file looks good + font metadata information is present Suggestions: 1) For Handwriting category font we use "cursive" name so change sans-serif to cursive in fontconfig file 2) version 4.3 is embedded in font metainfo so let's use that 3) $ appstream-util validate pecita.metainfo.xml pecita.metainfo.xml: FAILED: • markup-invalid : <id> does not have correct extension for kind • tag-missing : <extends> is not present • style-invalid : <summary> requires sentence case • style-invalid : <p> cannot contain a hyperlink • style-invalid : <p> does not end in '.|:|!' • style-invalid : Not enough <p> tags for a good description Validation of files failed => fix messages 3,4,5 from above in metainfo xml file 4) Create wiki page for this font as given in your other font package review. 5) use oflb as prefix foundry -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
