https://bugzilla.redhat.com/show_bug.cgi?id=1174974



--- Comment #3 from Zbigniew JÄ™drzejewski-Szmek <[email protected]> ---
Please reflow %description. Also please add some information about what the
package does, except being a fork.

Consider changing nosetests to nostests-%{python2_version} for clarity.

Use %license for COPYING.txt

Consider adding the following snippet:
"""
# Use the same directory of the main package for subpackage licence and docs
%global _docdir_fmt %{name}
"""

Package doesn't build: the patch also changes .pyc file. Wouldn't it be better
to simply skip the test using nosetest option instead of patching it out?

I think python2-devel is preferred to python-devel.

Otherwise looks OK, fedora-review has nothing interesting to say.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to