https://bugzilla.redhat.com/show_bug.cgi?id=1091659
--- Comment #26 from Michael Schwendt (Fedora Packager Sponsors Group) <[email protected]> --- This is _not_ about forcing people. It is about trying to give hints and general guidance beyond following existing guidelines. "People" are free to ignore such advice. It is my experience that patch is safer than sed without guards, and it would not be the first time a packager is bitten by a failing sed match. A worst-case example is a lazy sed subst that fails to replace something that enters the built executables "silently" without making the build fail (e.g. paths, config changes). So, guards are a good thing. Add them where you see the benefit. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
