https://bugzilla.redhat.com/show_bug.cgi?id=1107800



--- Comment #13 from Dave Love <[email protected]> ---
(In reply to Orion Poplawski from comment #12)

> From https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags 
> 
> "Adding to and overriding or filtering parts of these flags is permitted if
> there's a good reason to do so; the rationale for doing so must be
> documented in the specfile."
> 
> So you're good to add them.  But I'd be very hesitant to remove any.

Good.  I wonder if that's changed -- it's not how I remembered it.

> > In some cases I hope you can, but I'd at least hope to be able to rebuild
> > with, say, -march=native added to xFLAGS.
> 
> But the build computer is quite likely very different than the one the code
> will run on, so -march=native will just break things.

I meant I'd hope to be able to take the srpm and rebuild it for the local
cluster,
but that looks out of context here.

> Package looks good now, so APPROVED.

Many thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to