Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611328 Jerome Glisse <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Jerome Glisse <[email protected]> 2010-07-15 15:24:46 EDT --- I am not an approved reviewer but specs is mostly ok, point that needs improvement/fixing : Requires on openssl shouldn't be needed as rpmbuild should automaticly add dependency (see fedora packaging guideline) Split each BuildRequires to have one per line, use libssh2-devel instead of libssh-devel (i don't think this change a lot from hydra perspective and i have the feeling that libssh-devel will eventualy disapear). Also correct version from 0:5.7-0 to 5.7-0 (or do i miss something about the 0: ?) * Naming is ok * spec file correctly named ! Meets packaging guidelines (beside the aforementioned issues) * Meets Licensing Guidelines GPLv3 ! Does not install a desktop file, but should for the frontend * Does not install manual pages, but upstream does not provide any. Nice description by the way. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
