https://bugzilla.redhat.com/show_bug.cgi?id=1194628



--- Comment #1 from Petr Ĺ abata <[email protected]> ---
Note: All the patched files are read-only.  I assume the patching could fail,
even though it currently doesn't.  Perhaps making them writable before patching
would be a good idea.

Ad Patch1 -- according to Web Assets guidelines, Fedora webservers provide
%{_webassetdir} in `/_sysassets', not `/.sysassets'.  Please, correct the
patch.

Consider bumping the minimum required version of EU::MM to 6.76 and using
NO_PACKLIST to simplify the SPEC.

The convert.t test doesn't actually convert anything.  Maybe you could enhance
it a bit?  However, that's beyond the scope of this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to