https://bugzilla.redhat.com/show_bug.cgi?id=1188093

Rex Dieter <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #20 from Rex Dieter <[email protected]> ---
ah, that is a recent guidelines change I'd forgotten about.  I won't treat it
as a blocker, but please do update to use %license tag prior to doing any
builds.

2 other minor things:

Please do include the comment:
# All MIT except for:
# libqtile/widget/pacman.py:GPL (v3 or later)
# libqtile/widget/google_calendar.py:Apache (v2.0)
near the License: tag, to explain what it's all about

you should add a %changelog (and ideally bump Release: tag) entry every time
you update things (even for reviews).


Otherwise, APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to