https://bugzilla.redhat.com/show_bug.cgi?id=1180723
--- Comment #23 from Mamoru TASAKA <[email protected]> --- Well, at lease please increase release number even during review process (i.e. 0.3.XXX -> 0.4.XXX) * Calling "rpm" inside rpmbuild is forbidden - While I don't remember where it is written as document (currently with google I just found http://www.redhat.com/promo/summit/2008/downloads/pdf/Wednesday_130pm_Tom_Callaway_OSS.pdf page 25), actually I remember that calling "rpm" inside rpmbuild process is forbidden. One of the reason is that rpmdb created inside mock chroot is created by rpm "outside" mock chroot - and calling rpm inside mock chroot may just see rpmdb corruption. * bash completion file treatment on scriptlets - Well, on second thought, I think that writing to modify the "actual" file (i.e. %_sysconfdir/%name/bash-completion) rather than ${bashcomp} (this is symlink) is preferable, - as it clearly shows that scriptlet is modifying files under %_sysconfdir and actually not modifying the files under %_datadir. I think only the above two issues are left. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
