https://bugzilla.redhat.com/show_bug.cgi?id=1186501



--- Comment #3 from Antonio Trande <[email protected]> ---
1- %define tilp_version 1.17
   %define _udevdir /lib/udev/rules.d

http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define

Why /lib/udev/rules.d and not %{_prefix}/lib/udev/rules.d ?

2- Release: 0%{?dist}

http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag

3-  cd docs
    make install DESTDIR=%{buildroot}

Compact version is

     make -C docs install DESTDIR=%{buildroot}

4-
   mkdir -p %{buildroot}/lib/udev/rules.d/
   cp %SOURCE1 %{buildroot}%{_udevdir}/69-libticables.rules

Compact (without 'mkdir' command) and correct version is 

   cp -a %SOURCE1 %{buildroot}%{_udevdir}/69-libticables.rules

5- %lang(fr) %{_datadir}/locale/fr/LC_MESSAGES/libticables2.mo

http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to