https://bugzilla.redhat.com/show_bug.cgi?id=1196373



--- Comment #4 from Raphael Groner <[email protected]> ---
(In reply to Christian Dersch from comment #3)
> Prior to review some questions and notes:
> * Are you sure, that you're packaging the correct stockfish? You're using
> the git from mcostalba. The git mentioned on stockfish homepage is
> https://github.com/official-stockfish/Stockfish 

Honestly, I do not know. There are currently 405 forks available ...
https://github.com/official-stockfish/Stockfish/network

> * Are there problems with the official release 6 or why are you packaging
> the snapshot?

See above. The mcostalba branch was in the original review (bug #1006197).

> * In my first run of fedora-review I got WARNING: Cannot download url:
> https://raw.githubusercontent.com/official-stockfish/Stockfish/master/
> AUTHORS#/stockfish-AUTHORS

This seems to be a generated file and must be accessed manually. Maybe github
blocks bots for this.

> * I haven't looked into detail yet, but it seems that the Makefile doesn't
> honor the compiler flags. Result: -debuginfo package looks wrong, for
> example no source inside.

Well, then we should implement our own build system, maybe cmake or
ninja/Shinobi?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to