https://bugzilla.redhat.com/show_bug.cgi?id=1197132



--- Comment #2 from Sandro Bonazzola <[email protected]> ---
(In reply to Mat Booth from comment #1)
> Couple of items from a quick glance at the spec:
> 
> * BuildRoot tag and %clean section is not necessary unless you plan to
> maintain this package in EPEL5 too, see
> https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag and
> https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
> 
> * You have nothing specified in your %doc tags
> 
> When making changes to your spec, don't forget to bump the release number
> (rpmdev-bumpspec command can do this for you) and re-upload a new spec file
> and source rpm.

Done
Spec URL: http://resources.ovirt.org/repos/staging/reflections.spec
SRPM URL:
http://resources.ovirt.org/repos/staging/reflections-0.9.9-2.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to