https://bugzilla.redhat.com/show_bug.cgi?id=1123579
Christos Triantafyllidis <christos.triantafylli...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |christos.triantafyllidis@gm
| |ail.com
--- Comment #3 from Christos Triantafyllidis
<christos.triantafylli...@gmail.com> ---
Hello Steve,
Thank you for your time on this and I apologize for the long delay on that
(the project I needed this for got postponed a bit).
On your comments:
- gems should require rubygems package
Note: Requires: rubygems missing in rubygem-colorize-doc
See: http://fedoraproject.org/wiki/Packaging:Ruby#RubyGems
fedora-review which produced this comment
is no longer correct here:
https://bugzilla.redhat.com/show_bug.cgi?id=1128094
submitted.
I didn't change anything on that. At any case the -doc file should not directly
require rubygems.
- It should be hopefully easy enough to get the tests to run
in %check
A simple execution of 'testrb -Ilib test' looks to do the job.
Done. I tried to use minitest but I couldn't make it run without changing
upstream's tests so I preferred to keep the Test::UNIT based ones.
- Drop the Buidrequires on rake , the guidelines say not
to use it for tests (not sure I actually agree with that but
that is what it says)
Done.
- All of the Requires and Provides should go for fc > 21. They
are automatic now.
Done.
- Use %{gem_install} rather than way you have for %install.
Not sure if I got what you mean correctly here. The current ruby packaging
guide says to not do so:
https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#.25build
- The README and CHANGELOG should be the docs package I would
say.
Done.
- The files %{gem_spec} and %{gem_instdir}/%{gem_name}.gemspec are the same
I would %exclude the latter. The first is needed runtime.
Done.
In addition I upgraded it to the latest upstream (0.7.5):
https://ctria.fedorapeople.org/packaging/rubygem-colorize/rubygem-colorize.spec
https://ctria.fedorapeople.org/packaging/rubygem-colorize/rubygem-colorize-0.7.5-1.fc21.src.rpm
Cheers,
Christos
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
