https://bugzilla.redhat.com/show_bug.cgi?id=1202379
--- Comment #3 from Richard Hughes <[email protected]> --- (In reply to Kalev Lember from comment #2) > ! The license text (COPYING) is included in %license > Can you use %license COPYING instead of %doc COPYING please? Fixed, thanks. > Requires(post): systemd > Requires(preun): systemd > Requires(postun): systemd Fixed. > Another question is if it should have %systemd_postun or > %systemd_postun_with_restart in %post? I don't know the answer to that, but > it probably depends on whether it is safe to restart the daemon during > package upgrades? At this stage, systemd_postun_with_restart makes more sense I guess; it's system activated and quit-on-idle so I don't think it matters much each way. New spec here: http://people.freedesktop.org/~hughsient/temp/fwupd.spec Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
