Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=516538 Orcan 'oget' Ogetbil <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] AssignedTo|[email protected] |[email protected] Flag| |fedora-review+ --- Comment #3 from Orcan 'oget' Ogetbil <[email protected]> 2010-07-18 21:01:18 EDT --- I made a full review on the package. There are two minor issues that can be fixed before committing. Otherwise, the package is good to go. - rpmlint says globus-gram-job-manager-setup-condor.src: W: invalid-url Source0: globus_gram_job_manager_setup_condor-4.4.tar.gz which can be ignored. ? Can you explain in the spec file where Source1 comes from, or its upstream status? Why do we need it instead of what comes with the default installation? * %{perl_vendorlib}/Globus is already owned by globus-gram-job-manager-scripts which is required by this package. You need to own %{perl_vendorlib}/Globus/GRAM instead. ----------------------------------------------------------------------- This package (globus-gram-job-manager-setup-condor) is APPROVED by oget ----------------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
